chore(build): prepare for releases#78
Open
wmontwe wants to merge 17 commits into
Open
Conversation
wmontwe
added
the
pr: stacked
wmontwe
force-pushed
the
chore-build-prepare-for-releases
branch
from
ad7c2d0 to
ab0dee1
Compare
# Conflicts: # gradle/libs.versions.toml
wmontwe
force-pushed
the
chore-build-prepare-for-releases
branch
from
ab0dee1 to
3ce3f0c
Compare
| val versionFile = versionManager.sourceFile() | ||
| ?: error("No version.properties file found to print the release tag.") | ||
|
|
||
| println("${versionFile.parentFile.name}-${version.toStringValue()}") |
Member
There was a problem hiding this comment.
Suggested change
| println("${versionFile.parentFile.name}-${version.toStringValue()}") | |
| logger.lifecycle("${versionFile.parentFile.name}-${version.toStringValue()}") |
| value: 'STOPSHIP:' | ||
| - reason: 'Forbidden TODO todo marker in comment, please do the changes or create an issue to address it.' | ||
| value: 'TODO:' | ||
| allowedPatterns: '(TODO|FIXME)\((@[a-zA-z0-9-]+|#[0-9-]+)\):' |
Member
There was a problem hiding this comment.
I would keep this. This allow us to add follow-up tasks without missing it
| - 'equals' | ||
| excludeLabeled: false | ||
| excludeReturnFromLambda: true | ||
| excludeGuardClauses: true |
Member
There was a problem hiding this comment.
I would keep this true. Guard clauses are very useful for pre-requisits validation and helps with redability.
|
|
||
| The publishing workflows expect these repository secrets: | ||
|
|
||
| - `MAVEN_CENTRAL_USERNAME` |
Member
There was a problem hiding this comment.
note about maven central: https://central.sonatype.org/publish/maven-central-publishing-limits/
We may need to check if that would not be an issue for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #77
Prepares the project for publishing Thunderbird Mobile Components releases.
Adds release and snapshot publishing workflows, BOM/release/publishing Gradle tasks, release tag and version validation support, and maintainer release documentation.
Also enables ABI validation, Dokka, Gradle isolated projects, and updates Detekt/build logic for the new release-ready setup.
Bumps dependencies to be on the same state as TfA. This includes migration to AGP 9.